renovate: update all monorepo modules always together #259
Conversation
Signed-off-by: Paul Holzinger <[email protected]>
Update the monorepo modules weekly with renovate to make sure our repos are recently up to date and test the latest code. Signed-off-by: Paul Holzinger <[email protected]>
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's b49c089e5fa16be06f36b3abfa050f27dfee783b. |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Weak LGTM; either way @timcoding1988 needs to approve to receive more email.
| }, | ||
|
|
||
| // Updates for the monorepo modules should be grouped into a single PR. | ||
| { |
There was a problem hiding this comment.
This would presumably replace a similar configuration in Podman.
Applying this also to Buildah and Skopeo makes sense.
I don’t know what this will do inside container-libs; it probably doesn’t really — I guess it would make a difference only if some out-of-container-libs consumer wanted to update one, but not all, of the modules to a more recent commit (not tag).
There was a problem hiding this comment.
This would presumably replace a similar configuration in Podman.
Right, I will remove the podman config.
I don’t know what this will do inside container-libs; it probably doesn’t really
Note in general this only groups updates into a single PR. It does not mean all updates get applied at once. If say there is only a common update available renovate still makes a PR with just that. If there is then also an image update it pushed that into the same PR.
SO AFAICT if renovate would try to update the modules in the monorepo it would have done so already itself with or without this extra config.
There was a problem hiding this comment.
SO AFAICT if renovate would try to update the modules in the monorepo it would have done so already itself with or without this extra config.
OK, that’s clearly fine.
|
LGTM |
3 participants
Update the monorepo modules weekly with renovate to make sure our repos
are recently up to date and test the latest code.